[FIX] tableview: Avoid unnecessary calls to setSortingEnabled#7109
Merged
markotoplak merged 1 commit intobiolab:masterfrom Jun 12, 2025
Merged
Conversation
... with extra side effects.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7109 +/- ##
==========================================
- Coverage 88.73% 88.73% -0.01%
==========================================
Files 332 332
Lines 73450 73451 +1
==========================================
Hits 65176 65176
- Misses 8274 8275 +1 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes: #7103
Description of changes
setSortingEnabled disconnects/reconnects Qt's internal connections to model.sort(), causing client
sortIndicatorChange connections to trigger before the model is actually sorted. Avoid unnecessary calls.
The strange thing is this should have been happening also on Qt < 6.8.
Includes